Skip to content

handle armRequired capability for espresso tests#1084

Merged
krzysieksulejczak merged 2 commits into
mainfrom
TO-2535/handle_armrequired_for_espresso
May 18, 2026
Merged

handle armRequired capability for espresso tests#1084
krzysieksulejczak merged 2 commits into
mainfrom
TO-2535/handle_armrequired_for_espresso

Conversation

@krzysieksulejczak

@krzysieksulejczak krzysieksulejczak commented May 13, 2026

Copy link
Copy Markdown
Contributor

Allow espresso session creation with armRequired capability to force test execution on arm-based infrastructure

@krzysieksulejczak krzysieksulejczak requested a review from a team as a code owner May 13, 2026 08:08
@krzysieksulejczak krzysieksulejczak force-pushed the TO-2535/handle_armrequired_for_espresso branch from ee631c4 to 1942980 Compare May 13, 2026 08:11
@krzysieksulejczak krzysieksulejczak added enhancement New feature or request espresso Pull requests that affect espresso integration labels May 13, 2026
@krzysieksulejczak krzysieksulejczak force-pushed the TO-2535/handle_armrequired_for_espresso branch 5 times, most recently from fe860ef to 0d69b03 Compare May 13, 2026 12:51
@anupam-sl anupam-sl requested a review from mayank-at-sauce May 15, 2026 11:53
@mayank-at-sauce

Copy link
Copy Markdown
Contributor

Hi @krzysieksulejczak
Correct me if i am wrong, but i think we need a CLI flag support — "internal/flags/emulator.go" doesn't parse armRequired, so you can set it in YAML but not via --emulator "name=...,armRequired=true". The iOS side already supports this in "internal/flags/simulator.go". A couple of smaller things too: the schema description is pretty generic compared to xcuitest's, which actually explains what the flag does, and the new ARMRequired line in newStartOptions could sit under a // VMD specific settings comment to match how xcuitest groups it.

@krzysieksulejczak krzysieksulejczak force-pushed the TO-2535/handle_armrequired_for_espresso branch from 0d69b03 to fbc8b41 Compare May 18, 2026 08:26
@krzysieksulejczak

Copy link
Copy Markdown
Contributor Author

Hi @mayank-at-sauce

I addressed the comments

@mayank-at-sauce

Copy link
Copy Markdown
Contributor

LGTM

@krzysieksulejczak krzysieksulejczak merged commit 5098cf9 into main May 18, 2026
16 checks passed
@krzysieksulejczak krzysieksulejczak deleted the TO-2535/handle_armrequired_for_espresso branch May 18, 2026 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request espresso Pull requests that affect espresso integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants